Patch Review Call: Difference between revisions
mNo edit summary |
RossBurton (talk | contribs) No edit summary |
||
| Line 1: | Line 1: | ||
We have patch review calls to discuss patches that are under review. Any review comments in the call should be submitted to the mailing list: the list is still the primary location for feedback. | We have patch review calls to discuss patches that are under review. Any review comments in the call should be submitted to the mailing list: the list is still the primary location for feedback. | ||
The process is mostly to step through the patches that are queued up in master-next, review them, and if further action (be it following up with the submitter, more testing, or a deeper review) is needed assign someone to do this. | |||
There are two meeting times: | There are two meeting times: | ||
| Line 10: | Line 12: | ||
Passcode: 450428<br /> | Passcode: 450428<br /> | ||
International numbers available: https://zoom.us/u/abKnJRHtHt | International numbers available: https://zoom.us/u/abKnJRHtHt | ||
The intention is to ensure that all patches merged have definitely had multiple eyes looking at them, patches that need serious review get assigned to someone, and patches that need further work get replied to on the list. | The intention is to ensure that all patches merged have definitely had multiple eyes looking at them, patches that need serious review get assigned to someone, and patches that need further work get replied to on the list. | ||
Revision as of 12:05, 26 February 2025
We have patch review calls to discuss patches that are under review. Any review comments in the call should be submitted to the mailing list: the list is still the primary location for feedback.
The process is mostly to step through the patches that are queued up in master-next, review them, and if further action (be it following up with the submitter, more testing, or a deeper review) is needed assign someone to do this.
There are two meeting times:
- Monday, 17:00 - 18:00 UK time
- Thursday, 10:00 - 11:00 UK time
The calls are held on Zoom.
Call Details
Meeting ID: 977 6239 7148
Passcode: 450428
International numbers available: https://zoom.us/u/abKnJRHtHt
The intention is to ensure that all patches merged have definitely had multiple eyes looking at them, patches that need serious review get assigned to someone, and patches that need further work get replied to on the list.
Future plans:
- Formalise the process further (prior art: the glibc patch review call)
- Move review pipeline from oe-core/master-next to patchwork
- Tooling: submit autobuilder status to patchwork so b4 can show status
